feat(logs): messages infinite scroll and live refresh #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
May 29, 2024
| @@ -66,7 +66,7 @@ export const ShowMessage: React.FC<{ message: MessageRow }> = ({ message }) => { | |||
| return { code: { padding: '0', whiteSpace: 'pre-wrap' } }; | |||
| }} | |||
| > | |||
| {JSON.stringify({ error: message.error || undefined, output: message.meta || undefined }, null, 2)} | |||
| {JSON.stringify({ error: message.error?.message || undefined, output: message.meta || undefined }, null, 2)} | |||
There was a problem hiding this comment.
is the || undefined necessary?
There was a problem hiding this comment.
yes because messge.error can be null and null is not automatically removed from json stringify, but undefined will be stripped.
| return hit._source!; | ||
| }); | ||
| if (opts.cursorBefore) { | ||
| // In case we set before we have to reverse the message since we inverted the sort |
There was a problem hiding this comment.
Can we add a link to elastic/elasticsearch#29449 Might be handy if we ever run into the limitation mentioned in the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes NAN-998
Contributes to NAN-908
More or less the same than #2213 The main diff here is that we don't need to update the current page state, so we use two cursor
cursorBeforeandcursorAfterthe former to live refresh (prepend) and the later to do infinite scroll (append).Changes
Add
cursorBeforeandcursorAfterto searchMessagesNote: there is no concept of search_before in Elasticsearch, you just reverse the sorting order and re-reverse the results to achieve it.
Implement live refresh and infinite scroll in the UI
Test
**(note the scrollbar changing position because we prepend, it's very hard to manage unless we use our own scroll bar
Screen.Recording.2024-05-28.at.10.42.08.mov